Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded "After deploy" steps in prepare-release.yml file #2663

Merged
merged 2 commits into from
Nov 16, 2023

Conversation

ecgan
Copy link
Member

@ecgan ecgan commented Nov 14, 2023

Changes proposed in this Pull Request:

In PR woocommerce/grow#89, there is an update to the prepare-release.yml file. This made some of our custom "after deploy" post steps redundant.

In this PR, we remove the custom "after deploy" post steps in our extension repo.

Detailed test instructions:

We can test this in the next release by following the steps here: https://github.com/woocommerce/facebook-for-woocommerce/wiki/Build-&-Release#release-basics

There should not be redundant or duplicated "After deploy" steps.

Additional details:

This is no longer needed because they are now implemented in woocommerce/grow#89.
@ecgan ecgan added the changelog: dev Developer-facing only change. label Nov 14, 2023
@ecgan ecgan requested a review from a team November 14, 2023 12:16
@ecgan ecgan self-assigned this Nov 14, 2023
@tomalec
Copy link
Member

tomalec commented Nov 16, 2023

New grow actions released :) This PR should be ready to merge.

@ecgan ecgan merged commit c4c7b6a into develop Nov 16, 2023
1 check passed
@ecgan ecgan deleted the feature/update-github-prepare-release branch November 16, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: dev Developer-facing only change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants