Changes property access of product id to public. #2618
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
Private access of $id property done in PR 2606, breaks the product feed functionality. The Product feed doesn't populate variable products. This is happening because the
id
can't be accessed by fbproductfeed.php file atfacebook-for-woocommerce/includes/fbproductfeed.php
Line 475 in b152860
This PR changes the access from private to public which restores the original product feed functionality.
phpcs
checks? Please removephpcs:ignore
comments in changed files and fix any issues, or delete if not practical.Screenshots:
Before:
After:
Detailed test instructions:
Changelog entry