common Makefile rules, basic direnv / asdf setup #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edvardm
force-pushed
the
feature/more-devexp-goodies
branch
from
99ae882
to
31b27e9
Compare
edvardm
force-pushed
the
feature/more-devexp-goodies
branch
from
31b27e9
to
5fdac2e
Compare
edvardm
commented
Nov 22, 2023
| # Note that rule should be idempotent and return immediately if there's nothing to do, so that | ||
| # eg. test can depend on this. Strictly speaking this depends on 'pyproject.toml' too, but often those changes | ||
| # are not relevant to dependencies and user can always do `make -B <rule> to force rebuild` | ||
| .make-dev-deps: poetry.lock |
There was a problem hiding this comment.
it might seem unnecessarily complex to have rule for just poetry install --sync, but like with many other rules, idea is to create trivial to use abstractions, so that it is easier to change tools afterwards without other needed changes
edvardm
commented
Nov 27, 2023
| @@ -0,0 +1,3 @@ | |||
| # this if config file for https://asdf-vm.com/ | |||
There was a problem hiding this comment.
Note that nothing would require use of asdf, but it would provide more convenient flow for those who use it
edvardm
commented
Nov 27, 2023
| @@ -0,0 +1,12 @@ | |||
| # Read .envrc settings in parent dirs if present | |||
There was a problem hiding this comment.
cf before. direnv would not be required, but provided here as sample file
edvardm
commented
Nov 27, 2023
| # needs only rule body (repeating .PHONY is not needed) | ||
| ###################################################################################################### | ||
|
|
||
| .PHONY: deps |
There was a problem hiding this comment.
Another option would be to comment these by default, so that rules that are not implemented are not visible with make help
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.