fix: use textEdit for completion items insertion #232
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The edge cases in different editors with regards to word boundaries has been too high (even for syntaxes in the same editor).
Since perhaps not all clients support it, adopting this without checking for clientCapabilities would be a breaking change. We keep the existing behavior for backwards compatibility.Nevermind, I'm looking at it wrong. From 3.16 is the new InsertReplaceEdit.textEdit
is as old as the spec.TODO:
Replaces #231
For #230