feat: Allow integrations to change the base for server-islands URLs #12320
+23
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See proposal withastro/roadmap#1043 to see the full reasoning behind this change.
This PR only contains the required changes to enable an integration to be built. However, I created a draft PR that shows an integration and the example that uses it #12304. Please look at that PR to see the full desired impact of this change.
Changes
With config:
Result:
Testing
A manual test has been run in the separate PR. No automated tests have been added.
Because this is a niche use-case I wanted to get feedback from the team before adding tests for it. If it is desirable, I will add an e2e test that creates a new server island fixture to test this.
Docs
No docs are needed for this as this is a very niche configuration option. We don't want to clutter the main astro config, hence why I didn't add the config to the "public" user-facing config. If this is something we want to override, let's only allow it to be overriden from an integration level.