fix: revert #12227 (#12351)

.changeset/friendly-radios-live.md

@@ -0,0 +1,5 @@
+---
+'astro': patch
+---
+
+Reverts a change made in `4.16.6` that prevented usage of `astro:env` secrets inside middleware in SSR

packages/astro/src/env/runtime.ts

@@ -1,16 +1,12 @@
 import { AstroError, AstroErrorData } from '../core/errors/index.js';
 import { invalidVariablesToError } from './errors.js';
-import { ENV_SYMBOL } from './runtime-constants.js';
 import type { ValidationResultInvalid } from './validators.js';
 export { validateEnvVariable, getEnvFieldType } from './validators.js';
 
 export type GetEnv = (key: string) => string | undefined;
 type OnSetGetEnv = (reset: boolean) => void;
 
-let _getEnv: GetEnv = (key) => {
-	const env = (globalThis as any)[ENV_SYMBOL] ?? {};
-	return env[key];
-};
+let _getEnv: GetEnv = (key) => process.env[key];
 
 export function setGetEnv(fn: GetEnv, reset = false) {
 	_getEnv = fn;

packages/astro/src/env/vite-plugin-env.ts

@@ -9,7 +9,6 @@ import {
 	VIRTUAL_MODULES_IDS_VALUES,
 } from './constants.js';
 import { type InvalidVariable, invalidVariablesToError } from './errors.js';
-import { ENV_SYMBOL } from './runtime-constants.js';
 import type { EnvSchema } from './schema.js';
 import { getEnvFieldType, validateEnvVariable } from './validators.js';
 
@@ -42,7 +41,11 @@ export function astroEnv({
 				fileURLToPath(settings.config.root),
 				'',
 			);
-			(globalThis as any)[ENV_SYMBOL] = loadedEnv;
+			for (const [key, value] of Object.entries(loadedEnv)) {
+				if (value !== undefined) {
+					process.env[key] = value;
+				}
+			}
 
 			const validatedVariables = validatePublicVariables({
 				schema,