Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.9 blog post #741

Merged
merged 20 commits into from
Jul 24, 2023
Merged

2.9 blog post #741

merged 20 commits into from
Jul 24, 2023

Conversation

matthewp
Copy link
Contributor

No description provided.

@netlify
Copy link

netlify bot commented Jul 20, 2023

Deploy Preview for astro-www-2 ready!

Name Link
🔨 Latest commit e08ef31
🔍 Latest deploy log https://app.netlify.com/sites/astro-www-2/deploys/64bec76270ebf700086de076
😎 Deploy Preview https://deploy-preview-741--astro-www-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed! Only a few minor changes I'd make! 🥳

src/content/blog/astro-290.mdx Outdated Show resolved Hide resolved
src/content/blog/astro-290.mdx Outdated Show resolved Hide resolved
src/content/blog/astro-290.mdx Outdated Show resolved Hide resolved
src/content/blog/astro-290.mdx Outdated Show resolved Hide resolved
src/content/blog/astro-290.mdx Outdated Show resolved Hide resolved
src/content/blog/astro-290.mdx Outdated Show resolved Hide resolved
src/content/blog/astro-290.mdx Outdated Show resolved Hide resolved
Copy link
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more comments, after Sarah's and mine's been addressed, LGTM!

src/content/blog/astro-290.mdx Outdated Show resolved Hide resolved
src/content/blog/astro-290.mdx Outdated Show resolved Hide resolved
src/content/blog/astro-290.mdx Outdated Show resolved Hide resolved
@matthewp matthewp marked this pull request as ready for review July 24, 2023 16:53
Copy link
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

});
```

## Hoisted script optimization
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we credit the author of the PR in this section? It'd be nice imo

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, good point, I'll add that.

Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @matthewp! Left some comments.

I almost wish we could include something like Ben’s video — https://twitter.com/BHolmesDev/status/1682206832423579649 — in the view transitions section, but occurred to me too late to be an option I think.

src/content/blog/astro-290.mdx Outdated Show resolved Hide resolved
src/content/blog/astro-290.mdx Outdated Show resolved Hide resolved
src/content/blog/astro-290.mdx Outdated Show resolved Hide resolved
src/content/blog/astro-290.mdx Outdated Show resolved Hide resolved
src/content/blog/astro-290.mdx Outdated Show resolved Hide resolved
src/content/blog/astro-290.mdx Outdated Show resolved Hide resolved
src/content/blog/astro-290.mdx Outdated Show resolved Hide resolved
@matthewp
Copy link
Contributor Author

@delucis Just chatted with @FredKSchott and hoping to add that video actually.

@matthewp matthewp merged commit fdb80c8 into main Jul 24, 2023
5 checks passed
@matthewp matthewp deleted the astro-290 branch July 24, 2023 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants