Integrations update #1315
Merged
Integrations update #1315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for astro-www-2 pending review.Visit the deploys page to approve it
|
delucis
reviewed
Nov 4, 2024
There was a problem hiding this comment.
Thanks @pascal-brand38! Left a couple of preliminary notes regarding the added dependencies. (These are also breaking the Netlify build due to the lock file being out of date, but I think we may not need them anyway.)
When running the script
npm run update:integrations -- --unsafe
homepage urls that return 404 status code are replaced
by the link to the package on npm
Closes withastro#1313
Signed-off-by: Pascal Brand <[email protected]>
pascal-brand38
force-pushed
the
integrations-update
branch
from
575a608
to
434c412
Compare
Signed-off-by: Pascal Brand <[email protected]>
delucis
reviewed
Nov 6, 2024
There was a problem hiding this comment.
Left one small note, but looks good to me — thanks @pascal-brand38!
Fryuni
reviewed
Nov 6, 2024
A homepage url is considered as wrong when: - the response is greater than 400 - or it does not respond Signed-off-by: Pascal Brand <[email protected]>
delucis
approved these changes
Nov 6, 2024
There was a problem hiding this comment.
Thanks again for taking care to add this @pascal-brand38! I’ll merge this and run the “unsafe” script now to test it out 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Browser Test Checklist
I have tested this PR on at least three of the following browsers:
Serie of 4 commits to fix close #1313.
It consists of an update of scripts/update-integrations.mjs:
Because #1313 is still in discussion, and as this script is used in nightly and weekly builds, I think special attention has to be paid. This is why this pull-request is open as a draft.
Thanks for your help!