Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sponsor logos #1294

Merged
merged 4 commits into from
Oct 23, 2024
Merged

Update sponsor logos #1294

merged 4 commits into from
Oct 23, 2024

Conversation

clearlyTHUYDOAN
Copy link
Contributor

Description

Updates sponsor logos to reflect current status of official sponsors as well as gold sponsors

  • Removes Storyblok as exclusive CMS sponsor
  • Adds Manifest as new gold sponsor

@clearlyTHUYDOAN clearlyTHUYDOAN self-assigned this Oct 23, 2024
Copy link

netlify bot commented Oct 23, 2024

Deploy Preview for astro-www-2 ready!

Name Link
🔨 Latest commit 7b88fee
🔍 Latest deploy log https://app.netlify.com/sites/astro-www-2/deploys/6718c24fa48d1c0008ebe2d3
😎 Deploy Preview https://deploy-preview-1294--astro-www-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
5 paths audited
Performance: 97 (🔴 down 2 from production)
Accessibility: 100 (no change from production)
Best Practices: 95 (🟢 up 1 from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@clearlyTHUYDOAN
Copy link
Contributor Author

Deploy shows that sponsor grid CSS might be more manual and we cannot simply remove the Storyblok logo. It currently looks like this after removing Storyblok and I'm afraid of ruining the CSS here.

My theory from inspecting the element is I have to update something related to the grid-template-columns or grid-cols-x related CSS or classes but I'm not sure @delucis. Any advice?

Screenshot 2024-10-22 at 10 29 29 PM

(As for the Manifest logo, I am currently asking them to re-supply an SVG with a transparent background.)

Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @clearlyTHUYDOAN!

I updated the classes on the sponsor grid to make it more tolerant of varying numbers of main sponsors. And I also found https://manifest.build/assets which included more SVG logos, so switched it out for one that looked more plausible, although you can change that again if they come back to you with something different.

Now looks like this:

image

@clearlyTHUYDOAN clearlyTHUYDOAN merged commit 3ed3a00 into main Oct 23, 2024
6 checks passed
@clearlyTHUYDOAN clearlyTHUYDOAN deleted the update-sponsor-logos branch October 23, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants