Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include astro-integration keyword in integrations catalogue #1285

Merged
merged 5 commits into from
Oct 8, 2024

Conversation

delucis
Copy link
Member

@delucis delucis commented Oct 7, 2024

We require the astro-integration keyword to make an npm package work with astro add (docs), but never actually tracked that in the integrations catalogue, requiring one of withastro or astro-component instead. This PR updates the integrations script to also treat astro-integration as a sufficient keyword to include a package in our catalogue and runs the update script to add a bunch of missing integrations.

Most notably this includes Expressive Code!

Copy link

netlify bot commented Oct 7, 2024

Deploy Preview for astro-www-2 ready!

Name Link
🔨 Latest commit 74654af
🔍 Latest deploy log https://app.netlify.com/sites/astro-www-2/deploys/6704fb479830f30009f48ca9
😎 Deploy Preview https://deploy-preview-1285--astro-www-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
5 paths audited
Performance: 96 (🔴 down 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 95 (🟢 up 3 from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@HiDeoo HiDeoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great change imo 👏 (and also avoids me a PR to list one of my integration so even better 😄)

@delucis delucis merged commit f01e455 into main Oct 8, 2024
6 checks passed
@delucis delucis deleted the chris/track-astro-integration-keyword branch October 8, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants