-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] Allow configuring argon2id parameters #4291
base: develop
Are you sure you want to change the base?
Conversation
libs/wire-subsystems/src/Wire/AuthenticationSubsystem/Interpreter.hs
Outdated
Show resolved
Hide resolved
libs/wire-subsystems/test/unit/Wire/MockInterpreters/HashPassword.hs
Outdated
Show resolved
Hide resolved
…ord.hs Co-authored-by: Matthias Fischmann <[email protected]>
Always make sure the options from the server config are used if /a.
(Data.reauthenticate uid Nothing) `catchE` \case | ||
ReAuthMissingPassword -> pure () | ||
ReAuthCodeVerificationRequired -> pure () | ||
ReAuthCodeVerificationNoPendingCode -> pure () | ||
ReAuthCodeVerificationNoEmail -> pure () | ||
ReAuthError e -> case e of | ||
AuthInvalidUser -> throwE LoginFailed | ||
AuthInvalidCredentials -> pure () | ||
AuthSuspended -> throwE LoginSuspended | ||
AuthEphemeral -> throwE LoginEphemeral | ||
AuthPendingInvitation -> throwE LoginPendingActivation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this change is extremely hard to understand, and i think it has at least one error hidden deep inside: BadCredentials and InvalidUser are flipped.
are all the changes in names, order, and structure really necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also #4271 (review)
2360f08
to
1f4d18e
Compare
- passwordHashingOptions are no longer optional in settings, expect helm chart to have set the right defaults. - Brig.Provider.DB no longer hashes password, it expects hashed password to be passed in. Functions at higher level call HashPassword effect. These will eventually move to AuthenticationSubsystem (or something similar for providers)
Optimize for test run time, not security.
Was here to inspect CI env.
Reorg changelog, so important things go on top.
https://wearezeta.atlassian.net/browse/WPB-9746
Checklist
changelog.d