Bloodhound / Opensearch #4261
Draft
Bloodhound / Opensearch #4261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
supersven
added
the
ok-to-test
supersven
force-pushed
the
supersven/bloodhound-opensearch
branch
2 times, most recently
from
7669b04
to
4b643a3
Compare
supersven
force-pushed
the
supersven/bloodhound-opensearch
branch
2 times, most recently
from
f331e51
to
1f6823e
Compare
echoes-hq
bot
added
the
echoes: technical-debt
To be aligned with the elasticsearch-ephemeral.
- Old ES is unfortunately incompatible to new Bloodhound
URL: http://0.0.0.0:5601 username: elastic password: changeme
We settled on OS 1.x.x with the infra team for now.
We won't run ElasticSearch and OpenSearch in parallel.
supersven
commented
Oct 16, 2024
| updateTeamSearchVisibilityInboundImpl :: forall r. (Member (Embed IO) r) => IndexedUserStoreConfig -> TeamId -> SearchVisibilityInbound -> Sem r () | ||
| updateTeamSearchVisibilityInboundImpl cfg tid vis = | ||
| void $ runInBothES cfg updateAllDocs | ||
| where | ||
| updateAllDocs :: ES.IndexName -> ES.BH (Sem r) () | ||
| updateAllDocs idx = do | ||
| r <- ES.updateByQuery idx query (Just script) | ||
| r <- hoistBH (embed @IO) $ ES.performBHRequest . fmap fst . ES.keepBHResponse $ ESR.updateByQuery @Value idx query (Just script) |
There was a problem hiding this comment.
This handling of version conflicts is probably broken here. See bitemyapp/bloodhound#295
supersven
force-pushed
the
supersven/bloodhound-opensearch
branch
from
2b268b2
to
91ef5f0
Compare
fisx
reviewed
Oct 18, 2024
| networks: | ||
| - demo_wire | ||
|
|
||
| opensearch-dashboard: |
There was a problem hiding this comment.
dashboard! neat! is there a good place to mention that so people might notice?
Comment on lines
+97
to
+98
| # TODO: This should not refer to Sven's fork. Hope that we will get this | ||
| # upstreamed soonish or push the branch to Wire's fork. |
fisx
reviewed
Oct 18, 2024
Comment on lines
+44
to
+46
| if ES.isSuccess resp | ||
| then pure () | ||
| else logAndThrow mkErr resp |
There was a problem hiding this comment.
Suggested change
| if ES.isSuccess resp | |
| then pure () | |
| else logAndThrow mkErr resp | |
| unless (ES.isSuccess resp) $ logAndThrow mkErr resp |
| logAndThrow :: (Member TinyLog r, Member (Error MigrationException) r, Show e) => (String -> MigrationException) -> e -> Sem r a | ||
| logAndThrow mkErr errMsg = do | ||
| Log.warn $ | ||
| Log.msg (Log.val ("An OpenSearch/ElasticSearch error appeared: " `BS.append` (encodeUtf8 . Text.pack . show) errMsg)) |
There was a problem hiding this comment.
Suggested change
| Log.msg (Log.val ("An OpenSearch/ElasticSearch error appeared: " `BS.append` (encodeUtf8 . Text.pack . show) errMsg)) | |
| Log.msg (Log.val ("An OpenSearch/ElasticSearch error occurred: " `BS.append` (encodeUtf8 . Text.pack . show) errMsg)) |
| case persistResponse of | ||
| Left _ -> throw $ PersistVersionFailed v $ show persistResponse | ||
| Right r -> | ||
| if ES.idxDocId r == docIdText |
There was a problem hiding this comment.
Shouldn't this still do something involving ES.isCreated?
Comment on lines
+139
to
+140
| castResponse :: forall context1 val1 context2 val2. BHResponse context1 val1 -> BHResponse context2 val2 | ||
| castResponse BHResponse {..} = BHResponse {..} |
There was a problem hiding this comment.
Huh? How does this work without casting the fields?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should only be released in combination with an infrastructure migration from ElasticSearch 6 to OpenSearch 1.3.
Ticket: https://wearezeta.atlassian.net/browse/WPB-10715
Checklist
changelog.d