fix: Asset message resend transfer status #WPB-11035 #3063
Conversation
echoes-hq
bot
added
the
echoes: bugs
github-actions
bot
added
🚨 Potential breaking changes
👕 size: S
type: bug / fix 🐞
labels
|
|
Bencher Report| Branch | fix/asset-message-transfer-status |
| Testbed | ubuntu-latest |
⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholdsCLI flag.
Click to view all benchmark results
| Benchmark | Latency | nanoseconds (ns) |
|---|---|---|
| com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles | 📈 view plot | 688,884.23 |
| com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory | 📈 view plot | 338,957,249.46 |
| com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark | 📈 view plot | 922,774,759.78 |
| com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark | 📈 view plot | 21,308,468.82 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3063 +/- ##
========================================
Coverage 52.70% 52.70%
========================================
Files 1317 1317
Lines 51108 51111 +3
Branches 4742 4742
========================================
+ Hits 26936 26938 +2
Misses 22247 22247
- Partials 1925 1926 +1
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Datadog ReportBranch report: ✅ 0 Failed, 3145 Passed, 106 Skipped, 29.02s Total Time |
| @@ -178,7 +178,10 @@ class RetryFailedMessageUseCase internal constructor( | |||
|
|
|||
| else -> handleError("Asset message with transfer status $assetTransferStatus cannot be retried") | |||
| } | |||
| .onSuccess { retrySendingMessage(it) } | |||
| .onSuccess { | |||
| updateAssetMessageTransferStatus(AssetTransferStatus.UPLOADED, message.conversationId, message.id) | |||
There was a problem hiding this comment.
Question: should the status be changed to UPLOADED before the message is actually uploaded? Maybe UPLOAD_IN_PROGRESS would be more appropriate and change to UPLOADED only after the successful resend 🤔
There was a problem hiding this comment.
I thought about that - but isnt that status only regarding the asset? We have the additional status for message PENDING etc. Also if we set up this status like that, we can see:
- Error sending
- Uploading
- Uploaded
- Message pending (until its sent)
- If there will be any connection problem the message will get back to failed state
https://wearezeta.atlassian.net/browse/WPB-11035
What's new in this PR?
Issues
When we resended asset message, we're not updating its status to uploaded hence the message was stuck with
Uploadingindicator foreverSolutions
Change the status to Uploaded before trying to again send the message
Testing
How to Test
UploadingstatePR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.