Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show sync retry state for internal build #WPB-11198 #3062

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

damian-kaczmarek
Copy link
Contributor

@damian-kaczmarek damian-kaczmarek commented Oct 15, 2024

StoryWPB-11198 [Android] indicate sync retry state in the app top bar

What's new in this PR?

Issues

Add more debug info in top bar when sync is waiting for the network. This is only available on internal builds.

Solutions

  • add delay to fail message state
  • top bar listens for network observer state

Dependencies (Optional)

Needs releases with:

Testing

How to Test

Disconnect from internet and run the app

Attachments (Optional)

Before After
image image

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor

github-actions bot commented Oct 15, 2024

Test Results

3 250 tests  ±0   3 144 ✅ ±0   4m 5s ⏱️ +14s
  555 suites ±0     106 💤 ±0 
  555 files   ±0       0 ❌ ±0 

Results for commit eb907e8. ± Comparison against base commit a2f0ead.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Oct 15, 2024

🐰 Bencher Report

Branchfeat/show-sync-retry-state
Testbedubuntu-latest

⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencynanoseconds (ns)
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles📈 view plot
⚠️ NO THRESHOLD
681,861.40
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory📈 view plot
⚠️ NO THRESHOLD
325,099,328.62
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark📈 view plot
⚠️ NO THRESHOLD
936,088,983.15
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark📈 view plot
⚠️ NO THRESHOLD
21,554,526.42
🐰 View full continuous benchmarking report in Bencher

@datadog-wireapp
Copy link

datadog-wireapp bot commented Oct 15, 2024

Datadog Report

Branch report: feat/show-sync-retry-state
Commit report: ca5bc2a
Test service: kalium-jvm

✅ 0 Failed, 3144 Passed, 106 Skipped, 30.22s Total Time

@codecov-commenter
Copy link

codecov-commenter commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 84.21053% with 3 lines in your changes missing coverage. Please review.

Project coverage is 52.70%. Comparing base (a2f0ead) to head (eb907e8).

Files with missing lines Patch % Lines
...com/wire/kalium/logic/sync/slow/SlowSyncManager.kt 77.77% 2 Missing ⚠️
...in/com/wire/kalium/network/NetworkStateObserver.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3062      +/-   ##
===========================================
- Coverage    52.70%   52.70%   -0.01%     
===========================================
  Files         1317     1317              
  Lines        51108    51112       +4     
  Branches      4742     4742              
===========================================
+ Hits         26936    26937       +1     
- Misses       22247    22249       +2     
- Partials      1925     1926       +1     
Files with missing lines Coverage Δ
...re/kalium/logic/data/sync/IncrementalSyncStatus.kt 100.00% <100.00%> (ø)
.../com/wire/kalium/logic/data/sync/SlowSyncStatus.kt 100.00% <100.00%> (ø)
...otlin/com/wire/kalium/logic/data/sync/SyncState.kt 100.00% <100.00%> (ø)
.../wire/kalium/logic/sync/ObserveSyncStateUseCase.kt 93.33% <100.00%> (ø)
...m/logic/sync/incremental/IncrementalSyncManager.kt 86.17% <100.00%> (+0.14%) ⬆️
...in/com/wire/kalium/network/NetworkStateObserver.kt 20.00% <0.00%> (ø)
...com/wire/kalium/logic/sync/slow/SlowSyncManager.kt 92.77% <77.77%> (-2.23%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2f0ead...eb907e8. Read the comment docs.

Copy link

sonarcloud bot commented Oct 18, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants