Reopen PR #25 and PR #31 #33
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's few value in providing three different ways to retrieve the srv announcer. In fact, it's debatable on whether this should belong in this ansible role at all, given it's not something necessary to deploy SFT, but something very specific to our environment (and the lack of service discovery). Simplify this, by only accepting ``` - srv_announcer_artifact_file_url - srv_announcer_artifact_checksum ``` Which needs to be set from the outside while instantiating this role. `srv_announcer_artifact_checksum` now is also piped directly to `get_url.checksum`, meaning it'll need to have the hashing algorithm and a colon in front.
* fix copying artifact instead of binary * set 'extra_opts' to strip the otherwise unpredicted root folder name of the archive content
This provides default artifacts, so importing the role will automatically pull in the latest version that's tested to be compatible.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewinding 2 PRs that were merged but recently removed from
developto not break existing places (e.g. CI) that depend on these roles here, while introducing fixes.