Skip to content

Commit

Permalink
conn: remove the log.Errorf for non-NFS protocol errors
Browse files Browse the repository at this point in the history
The current code is calling log.Errorf for file system errors.
File system errors can be frequent, as in a shell searching $PATH.

These errors will be visible to the NFS client, and the NFS server
are very confusing when running shells on NFS-mounted file
systems, since the shell will handle the error.

The shell is just one example; searches of LD_LIBRARY_PATH,
/usr/include, etc: all produce copiuos error messages that
are not needed. The error is returned to the client and
can be handled there.

Note that if there is a protocol-level error, such as failure
to return a response packet, the error prints will still happen.
In that case, it may be appropriate.

Fixes #117.

Signed-off-by: Ronald G Minnich <[email protected]>
  • Loading branch information
rminnich committed Apr 24, 2024
1 parent ea1b85e commit 04b947a
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion conn.go
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,6 @@ func (c *conn) handle(ctx context.Context, w *response) error {
return drainErr
}
if appError != nil && !w.responded {
Log.Errorf("call to %+v failed: %v", handler, appError)
if err := c.err(ctx, w, appError); err != nil {
return err
}
Expand Down

0 comments on commit 04b947a

Please sign in to comment.