Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: integrate Expeditor to instead of the readline #98

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lafirest
Copy link

No description provided.

@willghatch
Copy link
Owner

willghatch commented Jan 20, 2024 via email

@lafirest
Copy link
Author

Hey, thanks, this is really cool! I've been wanting to integrate expeditor. I would like one change, though, which is that I want it to be an option, not the only behavior. IE can you change this so that there is still a command line flag for the old behavior? I'm happy for expeditor to be the default, but I still want readline-lib and the raw input with neither editor to be available.

On Fri, Jan 19, 2024 at 11:24:06PM -0800, lafirest wrote: You can view, comment on, or merge this pull request online at: #98 -- Commit Summary -- * feat: integrate Expeditor to instead of the readline -- File Changes -- M rash/info.rkt (7) M rash/private/rashrc-lib.rkt (10) M rash/repl.rkt (107) -- Patch Links -- https://github.com/willghatch/racket-rash/pull/98.patch https://github.com/willghatch/racket-rash/pull/98.diff -- Reply to this email directly or view it on GitHub: #98 You are receiving this because you are subscribed to this thread. Message ID: @.***>

thank for your reply, you are right, the Expeditor also need some patch for a better experience, thus currently this should be a option

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants