Set up user-agent for PCS stored requests #1350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johngian
force-pushed
the
fix-user-agents
branch
2 times, most recently
from
e38338d
to
dd606bd
Compare
|
Skipping a failed test because it looks unrelated to the patch. |
johngian
force-pushed
the
fix-user-agents
branch
2 times, most recently
from
5f979d9
to
48e12f8
Compare
Endpoints affected: * summary * mobile-html * media-list Top level config is not maintained when custom headers are defined on hyper requests. Also top level config is not available on template expansion, thus we need to redefine the user-agent in multiple places.
johngian
force-pushed
the
fix-user-agents
branch
from
48e12f8
to
c0c69b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Endpoints affected:
Top level config is not maintained when custom headers are
defined on hyper requests. Also top level config is not available
on template expansion, thus we need to redefine the user-agent in
multiple places.
Bug: https://phabricator.wikimedia.org/T319365