Feature/0.8 diamond version #222
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unibeck
force-pushed
the
feature/0.8_diamond_version
branch
from
f0498ee
to
7db93d0
Compare
|
@mudgen as discussed, it would great to get your stamp of approval, at least on the Diamond specific work. It is pretty straight forward, I copied the latest contract from https://github.com/mudgen/diamond-3-hardhat to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #160
I copied the latest contracts from here https://github.com/mudgen/diamond-3-hardhat, which use solidity version 0.8. I also had to update the hardhat-deploy specific
Diamantairecontract. Lastly, I updated hardhat to compile the contracts with the latest supported version 0.8.9, instead of 0.7.