Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solidity 0.8 Diamond Version #160

Open
mudgen opened this issue Jul 20, 2021 · 2 comments · May be fixed by #222
Open

Solidity 0.8 Diamond Version #160

mudgen opened this issue Jul 20, 2021 · 2 comments · May be fixed by #222

Comments

@mudgen
Copy link
Contributor

mudgen commented Jul 20, 2021

Please add a diamond version that supports Solidity 0.8. An example of such an implementation is here: https://github.com/mudgen/diamond-3-hardhat
This was referenced Nov 11, 2021
Open
Closed
@unibeck unibeck mentioned this issue Nov 28, 2021
Closed
@wighawag
Copy link
Owner

wighawag commented Feb 1, 2022

in hardhat-deploy@next I revamped the diamond deployment

I got rid of the Diamantaire and the new diamond is the one here.
Plus you can now specifiy your own implementation too

It has not been tested but if you could try it out that would help me

this is the new DIamondOptions :

hardhat-deploy/types.ts

Lines 80 to 99 in e8737d5

export interface DiamondOptions extends TxOptions {
diamondContract?: string | ArtifactData; // TODO
diamondContractArgs?: any[];
owner?: Address;
// defaultLoopeFacet?: boolean; // TODO // always there
defaultOwnershipFacet?: boolean;
defaultCutFacet?: boolean;
facets: DiamondFacets;
log?: boolean;
libraries?: Libraries;
linkedData?: any; // JSONable ?
upgradeIndex?: number;
execute?: {
contract?: string | {name: string; artifact: string | ArtifactData};
methodName: string;
args: any[];
};
deterministicSalt?: string;
facetsArgs?: any[];
}

@mudgen
Copy link
Contributor Author

mudgen commented Feb 1, 2022

Awesome, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/0.8 diamond version BuffChain/hardhat-deploy
2 participants
@mudgen @wighawag