Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Remove tags from news (1) #423

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Conversation

frankystone
Copy link
Contributor

@frankystone frankystone commented Apr 16, 2023

This has to be done before we update to django 4.2, because the references to the tagging app (which might get removed at all) are needed. Although this could be made simpler, imho, i decided to go the official django way and squash all migrations for the news. The advantage of this workflow is to have in the end only one migration file (instead of 4). This must be a two-step process with two separate PR's:

  1. PR (this one): Removes the tags field from the model in news
  2. PR (after the first PR got merged): Will remove old migrations files and the references to obsolete migrations in 0001_squashed_0004_remove_post_tags.py (that is: removing the line starting with replaces)
    To get this in:

Merge this branch
run ./manage.py migrate

@SirVer
Copy link
Contributor

SirVer commented May 6, 2023

Looks good to me. Thanks for working on this!

@bunnybot bunnybot added review:approve The pull request has been approved. and removed review:approve The pull request has been approved. labels Apr 2, 2024
@bunnybot bunnybot changed the title Remove tags from news (1) WIP: Remove tags from news (1) Jul 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review:approve The pull request has been approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants