This repository has been archived by the owner on Nov 8, 2021. It is now read-only.
Added option to remove email domain from usernames - with support for pagination #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. |
mvanbaak
approved these changes
Jul 9, 2019
mvanbaak
approved these changes
Aug 13, 2019
|
@michaelwittig Is there anything stopping a merge of this PR ? |
|
my only concern is that we have no test for this... there was no need for testing pagination before and I don't see how this could be accomplished easily. Any ideas? |
|
How about adding a variable for the '--max-items' parameter and setting it to 1 to test the pagination feature? This would negate the need for more than 50 users in the test account. |
Fixed order - get ec2 tags before switching to specific role for getting users
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on: #126
Added support for pagination when listing all users