Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Fix errros in the ascii specs of RuboCop (#1037)
Follow up #1031 (comment) and reverts #1028. This PR fixes the following error: ```console $ ci/run_rubocop_specs (snip) ==> Failed Examples rspec # RuboCop::Cop::Lint::PercentStringArray with binary encoded source adds an offense and corrects when tokens contain quotes rspec # RuboCop::Cop::Lint::PercentStringArray with binary encoded source accepts if tokens contain no quotes rspec './spec/rubocop/cop/layout/end_of_line_spec.rb[1:3:6:2]' # RuboCop::Cop::Layout::EndOfLine when EnforcedStyle is lf and the default external encoding is US_ASCII can inspect non-UTF-8 encoded source with proper encoding comment rspec './spec/rubocop/cop/layout/end_of_line_spec.rb[1:3:5:2]' # RuboCop::Cop::Layout::EndOfLine when EnforcedStyle is lf and there are many lines ending with CR+LF can inspect non-UTF-8 encoded source with proper encoding comment rspec './spec/rubocop/cop/layout/end_of_line_spec.rb[1:2:6:2]' # RuboCop::Cop::Layout::EndOfLine when EnforcedStyle is crlf and the default external encoding is US_ASCII can inspect non-UTF-8 encoded source with proper encoding comment rspec './spec/rubocop/cop/layout/end_of_line_spec.rb[1:2:5:2]' # RuboCop::Cop::Layout::EndOfLine when EnforcedStyle is crlf and there are many lines ending with LF can inspect non-UTF-8 encoded source with proper encoding comment rspec './spec/rubocop/cop/lint/percent_symbol_array_spec.rb[1:1:11:2]' # RuboCop::Cop::Lint::PercentSymbolArray detecting colons or commas in a %i/%I string with binary encoded source accepts if tokens contain no quotes rspec './spec/rubocop/cop/lint/percent_symbol_array_spec.rb[1:1:11:1]' # RuboCop::Cop::Lint::PercentSymbolArray detecting colons or commas in a %i/%I string with binary encoded source registers an offense and corrects when tokens contain quotes ``` #1028 has an issue with the fix, causing RuboCop's CI to fail. This PR prioritizes avoiding CI failures, so for now, it reverts the above change. Improvements for handling warnings in Ruby 3.4.0dev and displaying clear results when whitequark/parser fails in the RuboCop CI matrix will be addressed separately.
- Loading branch information