Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper Content-Type header on CCIP POST requests #2876

Merged
merged 3 commits into from
Oct 17, 2024
Merged

Conversation

m1guelpf
Copy link
Contributor

@m1guelpf m1guelpf commented Oct 17, 2024

Currently, CCIP POST requests are sent without Content-Type headers, which makes requests fail for servers that reject the body if the header isn't present.


PR-Codex overview

This PR focuses on enhancing the CCIP functionality by ensuring that POST requests include the appropriate Content-Type header, which is essential for correctly indicating the format of the data being sent.

Detailed summary

  • In the ccip.ts file, a headers object is created for POST requests, setting Content-Type to application/json.
  • The fetch call is updated to include the newly created headers object.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Oct 17, 2024

@m1guelpf is attempting to deploy a commit to the Wevm Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

changeset-bot bot commented Oct 17, 2024

🦋 Changeset detected

Latest commit: ada370f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
viem Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jxom jxom merged commit 3759bee into wevm:main Oct 17, 2024
2 of 5 checks passed
@github-actions github-actions bot mentioned this pull request Oct 17, 2024
@m1guelpf m1guelpf deleted the patch-1 branch October 17, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants