fix: update setTimeout
return type in socket.ts
#2860
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we install Viem we get a Typescript issue because
Timer
is not defined in some environments. Instead, we can look at the return type forsetTimeout
so that this works well across Node and web environments.PR-Codex overview
This PR focuses on updating the type of the
keepAliveTimer
variable in thesrc/utils/rpc/socket.ts
file to improve type safety and clarity.Detailed summary
keepAliveTimer
fromTimer | undefined
toReturnType<typeof setInterval> | undefined
..changeset/small-pianos-agree.md
file indicating the patch forviem
and the update to the internalkeepAliveTimer
type.