-
-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1948 Add Specifying Encoder Rule #2082
base: master
Are you sure you want to change the base?
Conversation
I used the following approach: The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Some minor things to refactor and we are ready to go!
For some reason our Actions do not start 🤔 |
.. versionadded:: 0.16.0 | ||
""" | ||
|
||
error_template = 'Found unespecified encoding' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found `open()` call without specified encoding
Maybe we should recreate this PR? Actions might ignore it for some reason. |
Sure, I will open a new PR with the changes you made. |
I opened a new PR #2084 with the changes in the |
Thank you, I will close new one, let's keep more history here. |
Sure. Also, I committed a new change to the conf.py file because the encoder was not correct and it was causing warnings. |
Encoding doesn't make sense when opened in binary mode. As the added tests don't have any binary mode tests I think this may be an oversight. What I'm not sure is if it should be OK to go without specifying encoding when in binary mode or if |
I have made things!
Closes #1948
Checklist
CHANGELOG.md
Related issues
🙏 Please, if you or your company is finding wemake-python-styleguide valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/wemake-python-styleguide. As a thank you, your profile/company logo will be added to our main README which receives hundreds of unique visitors per day.