-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dependency dashboard #221
base: master
Are you sure you want to change the base?
Add dependency dashboard #221
Conversation
This fixes a bug where the search returns mrs that are not related to the current dependency. For example searching for sidekiq also returns the sidekiq-status dependency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh wow! Thanks!
I have several questions:
- Can we split this feature into a separate file?
- Can we adds docs about this feature into README.md?
What exactly do you mean by 1? Creating separate pipelines or just extracting the methods? |
@Tranquility both 🙂 |
Not sure I like that idea. We are basically just keeping statistics now and update the issue in the end. If we extract this into a new file we will either have a lot of duplication or we need to reorganize the whole project to prevent that. And moving it into a separate pipeline means we will have lot more ci jobs. Right now merging this branch should not change the behavior at all (except for the bug fix commit of cause) if the feature is not enabled. |
Ok, this makes sense! What about splitting this script into a separate file just for better readability? |
I think that makes sense in general. It would also improves the testabilty so we could add some tests as well. But I don't know when I will be able to work on that. |
No worries, @Tranquility! Take your time! |
This creates an issue for each language that contains all the dependencies that need updates. It looks like this:
Dependency Dashboard ruby
20 of 86 bundler dependencies are out of date.
It also fixes a bug with finding open merge requests. That I found because the dashboard lists the merge requests that belong to the dependency. The search returns all MRs that have the dependency name in the title. So the dependency dashboard listed the MR for sidekiq-status gem as MR for sidekiq.