-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add client and server versions of generators (webrpc, schema and ridl schema) #72
Conversation
6df17be
to
576c71e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few comments, ideas.
2a28a38
to
c3ec55a
Compare
2263a00
to
10705b1
Compare
4e22f0f
to
5eeffb4
Compare
6dadae4
to
1e5ccc0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few nits
a2fdc81
to
41d91be
Compare
7729840
to
5667308
Compare
be4bcf7
to
627a5ed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Results in:
Before this can be merged, we need to merge this one: https://github.com/webrpc/webrpc/pull/310/files