Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add client and server versions of generators (webrpc, schema and ridl schema) #72

Merged
merged 10 commits into from
Oct 18, 2024
Merged

Add client and server versions of generators (webrpc, schema and ridl schema) #72

merged 10 commits into from
Oct 18, 2024

Conversation

LukasJenicek
Copy link
Contributor

@LukasJenicek LukasJenicek commented Sep 30, 2024 •
edited
Loading 

curl -v -H "Content-Type: application/json" -H "Webrpc: [email protected];gen-golang@unknown;[email protected]" -X POST http://localhost:4242/rpc/ExampleService/Version

Results in:

{
  "version": {
    "webrpcVersion": "v1",
    "schemaVersion": "[email protected]",
    "schemaHash": "bd2f9fc6bee7f200ba8b56fe1f287193bc5208de",
    "clientGenVersion": {
      "WebRPCGenVersion": "v0.19.3",
      "TmplTarget": "gen-golang",
      "TmplVersion": "unknown",
      "SchemaVersion": "[email protected]"
    },
    "serverGenVersion": {
      "WebRPCGenVersion": "v0.19.3",
      "TmplTarget": "gen-golang",
      "TmplVersion": "unknown",
      "SchemaVersion": "[email protected]"
    }
  }
}

Before this can be merged, we need to merge this one: https://github.com/webrpc/webrpc/pull/310/files

@LukasJenicek LukasJenicek force-pushed the version_headers branch 2 times, most recently from 6df17be to 576c71e Compare September 30, 2024 08:44
david-littlefarmer
david-littlefarmer reviewed Sep 30, 2024
View reviewed changes
Copy link

@david-littlefarmer david-littlefarmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments, ideas.

_examples/golang-basics/example.gen.go Outdated Show resolved Hide resolved
_examples/golang-basics/example.gen.go Show resolved Hide resolved
@LukasJenicek LukasJenicek force-pushed the version_headers branch 3 times, most recently from 2a28a38 to c3ec55a Compare October 7, 2024 08:26
VojtechVitek
VojtechVitek reviewed Oct 7, 2024
View reviewed changes
_examples/golang-basics/golang-basics Outdated Show resolved Hide resolved
main.go.tmpl Outdated Show resolved Hide resolved
main.go.tmpl Outdated Show resolved Hide resolved
@LukasJenicek LukasJenicek force-pushed the version_headers branch 5 times, most recently from 2263a00 to 10705b1 Compare October 7, 2024 10:24
@VojtechVitek VojtechVitek mentioned this pull request Oct 7, 2024
Merged
@LukasJenicek LukasJenicek force-pushed the version_headers branch 3 times, most recently from 4e22f0f to 5eeffb4 Compare October 7, 2024 11:35
VojtechVitek
VojtechVitek reviewed Oct 16, 2024
View reviewed changes
main.go.tmpl Outdated Show resolved Hide resolved
main.go.tmpl Outdated Show resolved Hide resolved
david-littlefarmer
david-littlefarmer reviewed Oct 17, 2024
View reviewed changes
Copy link

@david-littlefarmer david-littlefarmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few nits

main.go.tmpl Outdated Show resolved Hide resolved
main.go.tmpl Outdated Show resolved Hide resolved
main.go.tmpl Outdated Show resolved Hide resolved
main.go.tmpl Outdated Show resolved Hide resolved
main.go.tmpl Outdated Show resolved Hide resolved
main.go.tmpl Show resolved Hide resolved
main.go.tmpl Outdated Show resolved Hide resolved
_examples/golang-basics/example.ridl Outdated Show resolved Hide resolved
@LukasJenicek LukasJenicek force-pushed the version_headers branch 3 times, most recently from a2fdc81 to 41d91be Compare October 17, 2024 09:25
david-littlefarmer
david-littlefarmer reviewed Oct 17, 2024
View reviewed changes
main.go.tmpl Outdated Show resolved Hide resolved
VojtechVitek
VojtechVitek approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@VojtechVitek VojtechVitek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@VojtechVitek VojtechVitek merged commit 8a2785a into master Oct 18, 2024
1 check passed
@VojtechVitek VojtechVitek deleted the version_headers branch October 18, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VojtechVitek VojtechVitek VojtechVitek approved these changes

@david-littlefarmer david-littlefarmer david-littlefarmer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LukasJenicek @VojtechVitek @david-littlefarmer