-
-
Notifications
You must be signed in to change notification settings - Fork 602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: handle SIGINT with prompt #2887
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2887 +/- ##
==========================================
- Coverage 94.96% 94.93% -0.03%
==========================================
Files 31 31
Lines 1708 1718 +10
Branches 486 486
==========================================
+ Hits 1622 1631 +9
- Misses 86 87 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add test for this, looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. For testing it, you may add a case in serve's smoketest only.
I am not sure how to mock |
Just run process using |
}); | ||
|
||
// TODO: fix for windows | ||
if (isWindows) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is not good to skip windows test here...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will see if I can test it on a windows machine locally.
@snitin315 let's rebase, I think it is finished and please don't ignore windows tests, I will fix it if it will have problems |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you rebase?
What kind of change does this PR introduce?
fix
Did you add tests for your changes?
WIP
If relevant, did you update the documentation?
NO
Summary
Does this PR introduce a breaking change?
No
Other information
NO