Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make copy command structs non-extensible #365

Merged
merged 2 commits into from
Oct 4, 2024
Merged

Make copy command structs non-extensible #365

merged 2 commits into from
Oct 4, 2024

Commits on Oct 4, 2024

  1. Make copy command structs non-extensible 

    These don't seem likely to be extended, and even if they were, it's not
clear that the same extensions would apply to all usages of these
structs. Since they have multiple usages, make them non-extensible.

These were also the only extensibility points in encoder commands
(IIRC), making encoding a bit more complex.

Fixes 224
    @kainino0x
    kainino0x committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    df7ca2a View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into copies-non-extensible

    @kainino0x
    kainino0x authored Oct 4, 2024
    Configuration menu
    Copy the full SHA
    3f6dfdc View commit details
    Browse the repository at this point in the history