-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GPUSurfaceConfiguration.colorSpace #362
Conversation
bikeshed: - naming of WGPUColorSpace (WGPUPredefinedColorSpace?) - capitalization of WGPUColorSpace_SRGB (Srgb? sRGB?) Fixes 200
* which may be either "unmanaged" or "sRGB". | ||
* Wasm implementations should support @ref WGPUColorSpace_SRGB and @ref WGPUColorSpace_DisplayP3. | ||
*/ | ||
WGPUColorSpace colorSpace; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we have the surface capabilities reflect the available color spaces?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We talked about this in #200 (comment) but it seemed complex in practice and not necessary yet. On the web we currently just support all three formats with all two color spaces, but in native I don't know if all of those combinations are possible, and certainly new color spaces might not be compatible with all formats or vice versa.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve then? :)
(docs updated)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
filed #366 for both colorspace and tonemapping capabilities
So, what happens if we specify a
|
@eliemichel The two concepts are orthogonal though they can be used together. Please check out this draft I opened a while ago and provide any feedback you might have on it: |
Closing this PR, I think we are moving color space and tone mapping to Emscripten extensions. |
bikeshedding:
Fixes #200