Merge branch 'release/v0.12.2'

webern-unibas-ch · May 31, 2024 · 8c6aa32 · 8c6aa32
2 parents 226fb96 + 9590380
commit 8c6aa32
Show file tree

Hide file tree

Showing 71 changed files with 3,699 additions and 2,371 deletions.
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -88,6 +88,12 @@
                         "modifiers": ["readonly"],
                         "format": ["UPPER_CASE"],
                         "trailingUnderscore": "allow"
+                    },
+                    {
+                        "selector": "objectLiteralProperty",
+                        "format": ["camelCase", "UPPER_CASE", "snake_case"],
+                        "leadingUnderscore": "allow",
+                        "trailingUnderscore": "allow"
                     }
                 ],
                 "@typescript-eslint/no-empty-function": "off",

diff --git a/.github/workflows/ci_workflow.yml b/.github/workflows/ci_workflow.yml
@@ -33,19 +33,19 @@ jobs:
         strategy:
             matrix:
                 os: [ubuntu-latest]
-                node-version: [18.19, 20.9] # TODO (when Angular allows it): 21.x
+                node-version: [18.19, 20.13]
 
         outputs:
             sha: ${{ steps.get-sha.outputs.SHA }}
 
         steps:
             - name: Harden Runner
-              uses: step-security/harden-runner@a4aa98b93cab29d9b1101a6143fb8bce00e2eac4 # v2.7.1
+              uses: step-security/harden-runner@f086349bfa2bd1361f7909c78558e816508cdc10 # v2.8.0
               with:
                   egress-policy: audit
 
             - name: Checkout repository
-              uses: actions/checkout@44c2b7a8a4ea60a981eaca3cf939b5f4305c123b # ratchet:actions/checkout@v4.1.5
+              uses: actions/checkout@a5ac7e51b41094c92402da3b24376905380afc29 # v4.1.6
               with:
                   fetch-depth: 0 # Get all history and branches
 
@@ -72,17 +72,17 @@ jobs:
                   yarn run test:ci
 
             - name: Upload code coverage
-              if: matrix.node-version == 20.9 # upload coverage report for current node version only
-              uses: codecov/codecov-action@6d798873df2b1b8e5846dba6fb86631229fbcb17 # v4.4.0
+              if: matrix.node-version == 20.13 # upload coverage report for current node version only
+              uses: codecov/codecov-action@125fc84a9a348dbcf27191600683ec096ec9021c # v4.4.1
               env:
                   CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
               with:
                   flags: unittests
                   env_vars: ${{ matrix.os }}, ${{ matrix.node-version }}
 
             - name: Perform SonarCloud Analysis
-              if: matrix.node-version == 20.9 && github.event_name != 'pull_request' && github.repository_owner == env.MAIN_REPO_OWNER # perform SonarCloud analysis only for current node version and not with pull requests or forks(token issue)
-              uses: SonarSource/sonarcloud-github-action@49e6cd3b187936a73b8280d59ffd9da69df63ec9 # ratchet:SonarSource/sonarcloud-github-action@v2.1.1
+              if: matrix.node-version == 20.13 && github.event_name != 'pull_request' && github.repository_owner == env.MAIN_REPO_OWNER # perform SonarCloud analysis only for current node version and not with pull requests or forks(token issue)
+              uses: SonarSource/sonarcloud-github-action@4006f663ecaf1f8093e8e4abb9227f6041f52216 # v2.2.0
               env:
                   GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # Needed to get PR information, if any
                   SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
@@ -101,7 +101,7 @@ jobs:
                   yarn run build:gh
 
             - name: Upload build artifacts
-              if: matrix.node-version == 20.9 # upload build artifacts for current node version only
+              if: matrix.node-version == 20.13 # upload build artifacts for current node version only
               uses: actions/upload-artifact@65462800fd760344b1a7b4382951275a0abb4808 # ratchet:actions/[email protected]
               with:
                   name: dist
@@ -125,16 +125,16 @@ jobs:
         strategy:
             matrix:
                 os: [ubuntu-latest]
-                node-version: [20.9]
+                node-version: [20.13]
 
         steps:
             - name: Harden Runner
-              uses: step-security/harden-runner@a4aa98b93cab29d9b1101a6143fb8bce00e2eac4 # v2.7.1
+              uses: step-security/harden-runner@f086349bfa2bd1361f7909c78558e816508cdc10 # v2.8.0
               with:
                   egress-policy: audit
 
             - name: Checkout repository
-              uses: actions/checkout@44c2b7a8a4ea60a981eaca3cf939b5f4305c123b # ratchet:actions/checkout@v4.1.5
+              uses: actions/checkout@a5ac7e51b41094c92402da3b24376905380afc29 # v4.1.6
               with:
                   # ref (branch, tag or SHA) to check out
                   ref: ${{ env.DEV_GH_PAGES_BRANCH }}
@@ -191,18 +191,18 @@ jobs:
         strategy:
             matrix:
                 os: [ubuntu-latest]
-                node-version: [20.9]
+                node-version: [20.13]
 
         steps:
             - name: Harden Runner
-              uses: step-security/harden-runner@a4aa98b93cab29d9b1101a6143fb8bce00e2eac4 # v2.7.1
+              uses: step-security/harden-runner@f086349bfa2bd1361f7909c78558e816508cdc10 # v2.8.0
               with:
                   egress-policy: audit
 
             - name: Checkout repository
-              uses: actions/checkout@44c2b7a8a4ea60a981eaca3cf939b5f4305c123b # ratchet:actions/checkout@v4.1.5
+              uses: actions/checkout@a5ac7e51b41094c92402da3b24376905380afc29 # v4.1.6
             - name: Set up node ${{ matrix.node-version}}
-              uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # ratchet:actions/setup-node@v4.0.2
+              uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v4.0.2
               with:
                   node-version: ${{ matrix.node-version }}
                   cache: 'yarn'
@@ -232,10 +232,10 @@ jobs:
         strategy:
             matrix:
                 os: [ubuntu-latest]
-                node-version: [20.9]
+                node-version: [20.13]
         steps:
             - name: Harden Runner
-              uses: step-security/harden-runner@a4aa98b93cab29d9b1101a6143fb8bce00e2eac4 # v2.7.1
+              uses: step-security/harden-runner@f086349bfa2bd1361f7909c78558e816508cdc10 # v2.8.0
               with:
                   egress-policy: audit
 

diff --git a/.github/workflows/codeql.yml b/.github/workflows/codeql.yml
@@ -26,23 +26,23 @@ jobs:
 
         steps:
             - name: Harden Runner
-              uses: step-security/harden-runner@a4aa98b93cab29d9b1101a6143fb8bce00e2eac4 # v2.7.1
+              uses: step-security/harden-runner@f086349bfa2bd1361f7909c78558e816508cdc10 # v2.8.0
               with:
                 egress-policy: audit
 
             - name: Checkout repository
-              uses: actions/checkout@44c2b7a8a4ea60a981eaca3cf939b5f4305c123b # v4.1.5
+              uses: actions/checkout@a5ac7e51b41094c92402da3b24376905380afc29 # v4.1.6
               with:
                   fetch-depth: 2
             # Initializes the CodeQL tools for scanning.
             - name: Initialize CodeQL
-              uses: github/codeql-action/init@b7cec7526559c32f1616476ff32d17ba4c59b2d6 # v3.25.5
+              uses: github/codeql-action/init@9fdb3e49720b44c48891d036bb502feb25684276 # v3.25.6
               with:
                   languages: ${{ matrix.language }}
             # If this step fails, then you should remove it and run the build manually (see below)
             - name: Autobuild
-              uses: github/codeql-action/autobuild@b7cec7526559c32f1616476ff32d17ba4c59b2d6 # v3.25.5
+              uses: github/codeql-action/autobuild@9fdb3e49720b44c48891d036bb502feb25684276 # v3.25.6
             - name: Perform CodeQL Analysis
-              uses: github/codeql-action/analyze@b7cec7526559c32f1616476ff32d17ba4c59b2d6 # v3.25.5
+              uses: github/codeql-action/analyze@9fdb3e49720b44c48891d036bb502feb25684276 # v3.25.6
               with:
                   category: '/language:${{matrix.language}}'
diff --git a/.github/workflows/dependency-review.yml b/.github/workflows/dependency-review.yml
@@ -17,11 +17,11 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Harden Runner
-        uses: step-security/harden-runner@a4aa98b93cab29d9b1101a6143fb8bce00e2eac4 # v2.7.1
+        uses: step-security/harden-runner@f086349bfa2bd1361f7909c78558e816508cdc10 # v2.8.0
         with:
           egress-policy: audit
 
       - name: 'Checkout Repository'
-        uses: actions/checkout@44c2b7a8a4ea60a981eaca3cf939b5f4305c123b # v4.1.5
+        uses: actions/checkout@a5ac7e51b41094c92402da3b24376905380afc29 # v4.1.6
       - name: 'Dependency Review'
         uses: actions/dependency-review-action@0c155c5e8556a497adf53f2c18edabf945ed8e70 # v4.3.2
diff --git a/.github/workflows/scorecards.yml b/.github/workflows/scorecards.yml
@@ -31,12 +31,12 @@ jobs:
 
     steps:
       - name: Harden Runner
-        uses: step-security/harden-runner@a4aa98b93cab29d9b1101a6143fb8bce00e2eac4 # v2.7.1
+        uses: step-security/harden-runner@f086349bfa2bd1361f7909c78558e816508cdc10 # v2.8.0
         with:
           egress-policy: audit
 
       - name: "Checkout code"
-        uses: actions/checkout@44c2b7a8a4ea60a981eaca3cf939b5f4305c123b # v4.1.5
+        uses: actions/checkout@a5ac7e51b41094c92402da3b24376905380afc29 # v4.1.6
         with:
           persist-credentials: false
 
@@ -71,6 +71,6 @@ jobs:
 
       # Upload the results to GitHub's code scanning dashboard.
       - name: "Upload to code-scanning"
-        uses: github/codeql-action/upload-sarif@b7cec7526559c32f1616476ff32d17ba4c59b2d6 # v3.25.5
+        uses: github/codeql-action/upload-sarif@9fdb3e49720b44c48891d036bb502feb25684276 # v3.25.6
         with:
           sarif_file: results.sarif
diff --git a/.github/workflows/visualize-repo.yml b/.github/workflows/visualize-repo.yml
@@ -14,12 +14,12 @@ jobs:
 
     steps:
       - name: Harden Runner
-        uses: step-security/harden-runner@a4aa98b93cab29d9b1101a6143fb8bce00e2eac4 # v2.7.1
+        uses: step-security/harden-runner@f086349bfa2bd1361f7909c78558e816508cdc10 # v2.8.0
         with:
           egress-policy: audit
 
       - name: Checkout repository
-        uses: actions/checkout@44c2b7a8a4ea60a981eaca3cf939b5f4305c123b # ratchet:actions/checkout@v4.1.5
+        uses: actions/checkout@a5ac7e51b41094c92402da3b24376905380afc29 # v4.1.6
         with:
           ref: develop
           token: ${{ secrets.REPO_TOKEN }}

diff --git a/.gitignore b/.gitignore
@@ -1,4 +1,4 @@
-# See http://help.github.com/ignore-files/ for more about ignoring files.
+# See https://docs.github.com/get-started/getting-started-with-git/ignoring-files for more about ignoring files.
 
 # Compiled output
 /dist
@@ -46,6 +46,7 @@ speed-measure-plugin*.json
 # Miscellaneous
 /.angular/cache
 /.cache/
+/.nx/cache
 .sass-cache
 /connect.lock
 /coverage

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,74 @@
 
 All notable changes to this project will be documented in this file. See [commit-and-tag-version](https://github.com/absolute-version/commit-and-tag-version) for commit guidelines.
 
+## [0.12.2](https://github.com/webern-unibas-ch/awg-app/compare/v0.12.1...v0.12.2) (2024-05-31)
+
+### Features
+
+-   **edition:** add TkaTableHeader model ([7d24681](https://github.com/webern-unibas-ch/awg-app/commit/7d2468181f450de9afb538e9d70d6d759e4641f8))
+-   **edition:** prepare TkaTableHeader for corrections ([db4b708](https://github.com/webern-unibas-ch/awg-app/commit/db4b708248e156e50d4b4c3cfc4bf0856477af5e))
+
+### Bug Fixes
+
+-   **app:** fix linting errors and warnings ([33db68d](https://github.com/webern-unibas-ch/awg-app/commit/33db68d28cb3c5ec411407edc2ebe89ec1593ec0))
+-   **assets:** fix source description op. 25 D ([21359e3](https://github.com/webern-unibas-ch/awg-app/commit/21359e369a269e900403e1b72d503f6902f43c78); thanks to [@masthom](https://github.com/masthom))
+-   **core:** simplify conversion of full text search response ([7548f51](https://github.com/webern-unibas-ch/awg-app/commit/7548f511e22be7b3decf81c9a21b9c656532e116))
+-   **edition:** don't adjust comment label for corrections ([25056f4](https://github.com/webern-unibas-ch/awg-app/commit/25056f44212b75a0b3e9abb57753d97752fbe38f))
+-   **edition:** fix direction of arrows in SheetFooter ([9085158](https://github.com/webern-unibas-ch/awg-app/commit/908515849e6a35c7d7c157bc8d1dba0ce32ad76a))
+-   **edition:** include check for rowtable sketch ids (SkRT) ([b8e0e94](https://github.com/webern-unibas-ch/awg-app/commit/b8e0e9489de1c916aec7b5068fe2d05341f57963))
+-   **edition:** pass down info about sketches to TkaTable ([df6f608](https://github.com/webern-unibas-ch/awg-app/commit/df6f60806c2848057d8f8b519a06093c5942bf1d))
+-   **edition:** remove placeholder for now available sources ([e122641](https://github.com/webern-unibas-ch/awg-app/commit/e12264195abe451311b03107a47d3e131c43a382))
+-   **edition:** simplify check for sketches ([2eee26f](https://github.com/webern-unibas-ch/awg-app/commit/2eee26f3de30a53d39ecd6c3d1771f580001e6ba))
+-   **edition:** use correct string for source evaluation ([a93aac9](https://github.com/webern-unibas-ch/awg-app/commit/a93aac9b1fa73377264c32f18378f86e09658783))
+-   **edition:** use correct string for textcritical comments ([71182dd](https://github.com/webern-unibas-ch/awg-app/commit/71182dd5486f8ea1dae6ae9a4bd6a86cb289b0a3))
+-   **edition:** use tka label component in SheetViewerSwitch ([7619f8a](https://github.com/webern-unibas-ch/awg-app/commit/7619f8a516302f113be8a672846b944c9b2f9b57))
+
+### Code Refactoring
+
+-   **edition:** improve creation of TkaTableHeader ([cf84944](https://github.com/webern-unibas-ch/awg-app/commit/cf84944d7e2ec0da47938e7f177998404b342d9b))
+-   **edition:** move isSketchId check into utility service ([e1bb971](https://github.com/webern-unibas-ch/awg-app/commit/e1bb9710e06a1a6c307b384c4ff33cc405ec4841))
+-   **edition:** move logic for tka label into component ([c092f46](https://github.com/webern-unibas-ch/awg-app/commit/c092f466e4701609195298d13254cba4aecb5d6e))
+-   **edition:** rename isTextcriticsForSketch -> isSketchId ([a3bddf4](https://github.com/webern-unibas-ch/awg-app/commit/a3bddf4ece151f0605b0fed45d4a7af342ab82b5))
+
+### Tests
+
+-   **core:** fix tests for cleanSubjectValueLabels ([f8c7a5d](https://github.com/webern-unibas-ch/awg-app/commit/f8c7a5d8fe7a5f8d7a43ee9499e204c4a4539886))
+-   **edition:** add tests for TkaTableHeaders ([b6a8da7](https://github.com/webern-unibas-ch/awg-app/commit/b6a8da75158d8aeb3a2e796237a2c8ff0508d8ee))
+-   **edition:** fix test limitation ([ddac1d1](https://github.com/webern-unibas-ch/awg-app/commit/ddac1d19a058805e330e8b240ca7825525fd6a01))
+-   **edition:** fix tests after changes ([2f71abd](https://github.com/webern-unibas-ch/awg-app/commit/2f71abdc4a68a46d629fba09f03be7f5f8244343))
+
+### Continuous Integration
+
+-   **app:** upgrade node to 20.13 ([bac64ac](https://github.com/webern-unibas-ch/awg-app/commit/bac64ac2f995a81caf174939c7150550bc6493a1))
+-   **gh-actions:** remove ratchet comment ([405416f](https://github.com/webern-unibas-ch/awg-app/commit/405416f73ff57fb3e4ba0bcfcef4cb7d472a0f55))
+
+### Documentation
+
+-   **README:** udpate supported minimal node version ([7f8117a](https://github.com/webern-unibas-ch/awg-app/commit/7f8117a131b32b8297caebbe0dcccfd1a28afbb6))
+
+### Build System
+
+-   **app:** add nx/cache to gitignore file ([6a443ef](https://github.com/webern-unibas-ch/awg-app/commit/6a443ef3e8b95acb82a4b2ba0807562b480f2f67))
+-   **app:** adjust config values after update to Angular v18 ([f1f363c](https://github.com/webern-unibas-ch/awg-app/commit/f1f363cf3188dc86ed513238c1be0fae907176dd))
+-   **app:** adjust content files after update to Angular v18 ([746ab15](https://github.com/webern-unibas-ch/awg-app/commit/746ab15e3bc080b1961d6fda7d0346518b6be1c2))
+-   **app:** update to Angular v18 ([0a927b1](https://github.com/webern-unibas-ch/awg-app/commit/0a927b1427fcb6753361f69afcd6cfa8ce0fc1e6))
+-   **app:** update to angular-eslint v18 ([d1abdef](https://github.com/webern-unibas-ch/awg-app/commit/d1abdef0da81519a4e83b199ab91ebe44c6bd50f))
+-   **deps-dev:** bump @compodoc/compodoc from 1.1.24 to 1.1.25 ([5d8b109](https://github.com/webern-unibas-ch/awg-app/commit/5d8b10954181116e98b8bfb2d7d31f838b346990))
+-   **deps-dev:** bump angular-cli-ghpages from 1.0.7 to 2.0.0 ([c882929](https://github.com/webern-unibas-ch/awg-app/commit/c8829293107ef3717556ef3c27a773f26790c852))
+-   **deps-dev:** bump eslint-plugin-jsdoc from 48.2.4 to 48.2.5 ([44999bc](https://github.com/webern-unibas-ch/awg-app/commit/44999bc64cb4098e8dfb755b64897c481651ac8c))
+-   **deps-dev:** bump eslint-plugin-jsdoc from 48.2.5 to 48.2.6 ([f9e178d](https://github.com/webern-unibas-ch/awg-app/commit/f9e178d54030154e1fc98473749abc2637dacc6d))
+-   **deps-dev:** bump eslint-plugin-jsdoc from 48.2.6 to 48.2.7 ([e7cae49](https://github.com/webern-unibas-ch/awg-app/commit/e7cae4913fc46bc391ba4ee03a15aca3cd4ad7d1))
+-   **deps-dev:** bump lint-staged from 15.2.4 to 15.2.5 ([295fee9](https://github.com/webern-unibas-ch/awg-app/commit/295fee9dd1b088619da3b8099e1dc0a6957245c4))
+-   **deps-dev:** bump the angular-eslint group across 1 directory with 5 updates ([a995dd7](https://github.com/webern-unibas-ch/awg-app/commit/a995dd7fa96889b1188ccfb233067db164041f4e))
+-   **deps-dev:** bump the typescript-eslint group with 2 updates ([b9b7989](https://github.com/webern-unibas-ch/awg-app/commit/b9b79894663e7a84ffb31a945a0bd99a1b448a9a))
+-   **deps:** bump actions/checkout from 4.1.5 to 4.1.6 ([f92b7cd](https://github.com/webern-unibas-ch/awg-app/commit/f92b7cd97492a7fa53aa00376128320a6fa66df5))
+-   **deps:** bump codecov/codecov-action from 4.4.0 to 4.4.1 ([ecc91d3](https://github.com/webern-unibas-ch/awg-app/commit/ecc91d349dc19534b5b178ab0bff1f5a89ba0a04))
+-   **deps:** bump github/codeql-action from 3.25.5 to 3.25.6 ([d4ca50e](https://github.com/webern-unibas-ch/awg-app/commit/d4ca50e8b6e039243f8b579f0c377026adf78ba4))
+-   **deps:** bump SonarSource/sonarcloud-github-action ([0586455](https://github.com/webern-unibas-ch/awg-app/commit/05864559d60eabf622b5d51c20e99a97ee0a4f48))
+-   **deps:** bump the angular group with 11 updates ([566e4bc](https://github.com/webern-unibas-ch/awg-app/commit/566e4bc190fb5fccfa6521933465fdd55bcab5a3))
+-   **deps:** bump zone.js from 0.14.2 to 0.14.6 ([30b5647](https://github.com/webern-unibas-ch/awg-app/commit/30b5647420ab78b431db611bbdf76b8fedd35f51))
+-   **deps:** update .github/workflows/ci_workflow.yml ([ca3c2f6](https://github.com/webern-unibas-ch/awg-app/commit/ca3c2f6aeffc10fa2eb7568e36bd32ef814f2de7))
+
 ## [0.12.1](https://github.com/webern-unibas-ch/awg-app/compare/v0.12.0...v0.12.1) (2024-05-15)
 
 ### Features

diff --git a/README.md b/README.md
@@ -2,7 +2,7 @@
 
 ![GitHub package.json version](https://img.shields.io/github/package-json/v/webern-unibas-ch/awg-app.svg)
 [![GitHub package.json dependency version (prod)](https://img.shields.io/github/package-json/dependency-version/webern-unibas-ch/awg-app/@angular/core?color=blue&label=angular&logo=angular)](https://github.com/angular/angular)
-![Node.js version](https://img.shields.io/badge/node.js-%3E=v18.19.0-blue)
+![Node.js version](https://img.shields.io/badge/node.js-%3E=v18.19.1-blue)
 ![GitHub commit activity](https://img.shields.io/github/commit-activity/m/webern-unibas-ch/awg-app)
 ![CI Workflow](https://github.com/webern-unibas-ch/awg-app/actions/workflows/ci_workflow.yml/badge.svg)
 [![codecov](https://codecov.io/gh/webern-unibas-ch/awg-app/graph/badge.svg?token=IO5EgI81R6)](https://codecov.io/gh/webern-unibas-ch/awg-app)
@@ -19,7 +19,6 @@ A prototype web application for the online edition of the [Anton Webern Gesamtau
 
 <img width="943" alt="app" src="https://github.com/musicEnfanthen/awg-app/assets/21059419/0673d981-558a-4519-8232-e570efa2985e">
 
-
 ## Table of Contents
 
 -   [Description](#description)