Skip to content
This repository has been archived by the owner on Dec 18, 2019. It is now read-only.

Let v4 support w3c drivers #32

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shinxi
Copy link

@shinxi shinxi commented Aug 21, 2019

  • Add w3c capabilities to the session command to let w3c drivers work correctly.

Reference: webdriverio/webdriverio#4380

Proposed changes

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have proposed the same patch to the new v5 repository

Further comments

Reviewers: @christian-bromann

* Add w3c capabilities to the session command to let w3c drivers work correctly.
@jsf-clabot
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

@emilyrohrbough
Copy link
Contributor

How has this been tested? One which browsers has this been tested in?

desiredCapabilities: this.desiredCapabilities
})
const jsonwpCaps = this.desiredCapabilities;
const w3cCapKeys = [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These don't match what exists in webdriver v5:
https://github.com/webdriverio/webdriverio/blob/e79328564e049fe6c81f0319ffe89d9293462e69/packages/webdriverio/src/constants.js#L369

looking at goog:chromeOptions and moz:firefoxOptions

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shinxi
Copy link
Author

shinxi commented Aug 22, 2019

How has this been tested? One which browsers has this been tested in?

@emilyrohrbough Sure, I'll add some tests later.

@christian-bromann
Copy link
Contributor

@shinxi I highly recommend to switch to v5 because v4 (even with this patch) is not 100% compatible with the WebDriver spec. You will end up spending more time fixing those kind of issues than rewriting your test suite into v5.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants