-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/browser support #150
Open
kwikwag
wants to merge
7
commits into
webauthn-open-source:master
Choose a base branch
from
kwikwag:fix/browser-support
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix/browser support #150
Commits on Dec 17, 2023
-
feat: dynamic webcrypto import - works on browser
NOTE: not tested on Node<16 (@peculiar/webcrypto fallback)
Configuration menu - View commit details
-
Copy full SHA for c8a94ea - Browse repository at this point
Copy the full SHA c8a94eaView commit details -
mark @peculiar/webcrypto dependency as optional
It's only required for node engines <16, which are no longer under Node.js maintenance.
Configuration menu - View commit details
-
Copy full SHA for ae6afbf - Browse repository at this point
Copy the full SHA ae6afbfView commit details -
While for some reason it works when installing from the online repo, it fails when installing the package from the filesystem. See https://stackoverflow.com/questions/39040108 This is poorly documented, but also see: - https://www.typescriptlang.org/docs/handbook/modules/reference.html#ambient-modules - https://www.typescriptlang.org/docs/handbook/modules/reference.html#import-types
Configuration menu - View commit details
-
Copy full SHA for e5eb8c4 - Browse repository at this point
Copy the full SHA e5eb8c4View commit details -
Configuration menu - View commit details
-
Copy full SHA for cca9547 - Browse repository at this point
Copy the full SHA cca9547View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1b9ea80 - Browse repository at this point
Copy the full SHA 1b9ea80View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7fb925e - Browse repository at this point
Copy the full SHA 7fb925eView commit details
Commits on Dec 21, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 32a8e0d - Browse repository at this point
Copy the full SHA 32a8e0dView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.