Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure maximum logging level #1

Merged

Conversation

sea-grass
Copy link

Fixes vmware-labs#253.

Adds a --log-level option to configure the actix_web logs that can be one of the valid log::LevelFilter options (off, error, warn, info, debug, trace). It will default to info if none is specified.

This is my first Rust-only PR. I'm sure some things can be more elegant, so please let me know 😄

@sea-grass
Copy link
Author

Migrated from the archived repository vmware-labs#267

@Angelmmiguel
Copy link

Hey @sea-grass,

Thank you for the PR! It looks great and it provides much more flexibility to the server. In the future, we will need to adopt the macro helpers (info!, debug!, etc.) to be consistent, although this is a great starting point 😄

Copy link

@Angelmmiguel Angelmmiguel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Angelmmiguel
Copy link

Btw, I hope you are enjoying your journey learning Rust!

@Angelmmiguel Angelmmiguel merged commit ba965ce into webassemblylabs:main Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configure maximum logging level
2 participants