Refactor formality translation context handling. #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NarkNiro
force-pushed
the
task/formality-refactor
branch
2 times, most recently
from
d0bb220
to
575051d
Compare
calien666
reviewed
Aug 29, 2024
NarkNiro
force-pushed
the
task/formality-refactor
branch
from
575051d
to
fa34b90
Compare
The problem with global formality configuration is true. That a target language has not been checked to see whether formality is supported. An error response from the DeepL API is returned for unsupported languages, which states ‘formality not supported’. To enable better handling for formality, only supported target languages. An additional formality field is added in the SiteConfiguration, which reflects the options of the API. The Formality field only appears for supported target languages, which is checked against the supported languages API. An upgrade wizard has been provided to simplify the conversion of the Formality configuration to the SiteConfiguration. Additionally, a DTO TranslateContext has been introduced, to centralise parameter handling for better handling of translation parameters.
NarkNiro
force-pushed
the
task/formality-refactor
branch
from
fa34b90
to
65a8fd2
Compare
calien666
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem with global formality configuration is true. That a target language has not been checked to see whether formality is supported. An error response from the DeepL API is returned for unsupported languages, which states ‘formality not supported’.
To enable better handling for formality, only supported target languages. An additional formality field is added in the SiteConfiguration, which reflects the options of the API.
The Formality field only appears for supported target languages, which is checked against the supported languages API.
An upgrade wizard has been provided to simplify the conversion of the Formality configuration to the SiteConfiguration.
Additionally, a DTO TranslateContext has been introduced, to centralise parameter handling for better handling of translation parameters.