Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import with use #375

Closed
wants to merge 1 commit into from
Closed

Import with use #375

wants to merge 1 commit into from

Conversation

Rotzbua
Copy link
Contributor

@Rotzbua Rotzbua commented Sep 27, 2023

No description provided.

Minishlink
Minishlink reviewed Sep 27, 2023
View reviewed changes
Copy link
Member

@Minishlink Minishlink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a rule in phpstan for this?

@Rotzbua
Copy link
Contributor Author

Rotzbua commented Sep 27, 2023 •
edited
Loading

Is there a rule in phpstan for this?

I could not find any rule. I think this is more a code style thing and phpstan is more a validator rather then a code style tool.

edit:
found cs fixer rule: https://cs.symfony.com/doc/rules/import/global_namespace_import.html
So up to you which style you prefer.

@Minishlink
Copy link
Member

Oh yes, a rule of php-cs-fixer sounds great. I don't really mind which rule is used but let's be consistent everywhere thanks to a rule

@Rotzbua
Copy link
Contributor Author

Rotzbua commented Sep 28, 2023

@Minishlink Added stricter cs fixer rules, so closed in favor of #377

@Rotzbua Rotzbua closed this Sep 28, 2023
@Rotzbua Rotzbua deleted the import_use branch March 12, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Minishlink Minishlink Minishlink left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rotzbua @Minishlink