Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relax feature-detection for <menclose> #21256

Merged
merged 1 commit into from
Jan 20, 2020
Merged

Relax feature-detection for <menclose> #21256

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 5 additions & 29 deletions mathml/support/feature-detection.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,35 +24,11 @@ var MathMLFeatureDetection = {
},

"has_menclose": function() {
if (!this.hasOwnProperty("_has_menclose")) {
document.body.insertAdjacentHTML("beforeend", "<math>\
<mrow style='font-size: 20px !important'>\
<mrow>\
<mrow>\
<mrow>\
<mtext>A</mtext>\
</mrow>\
</mrow>\
</mrow>\
</mrow>\
<menclose notation='box' style='font-size: 20px !important'>\
<menclose notation='box'>\
<menclose notation='box'>\
<menclose notation='box'>\
<mtext>A</mtext>\
</menclose>\
</menclose>\
</menclose>\
</menclose>\
</math>");
var math = document.body.lastElementChild;
// The boxes will make menclose wider than mrow, if the former is supported.
this._has_menclose =
math.lastElementChild.getBoundingClientRect().width -
math.firstElementChild.getBoundingClientRect().width > 5;
document.body.removeChild(math);
}
return this._has_menclose;
// Just check whether <mrow> is supported because discussion on this is
// still open ( https://github.com/mathml-refresh/mathml/issues/105 )
// and it would have to behave at least like an mrow, even if it becomes
// an unknown element at the end.
return this.has_mrow();
},

"has_merror": function() {
Expand Down