Skip to content

Commit

Permalink
webnn: Forward-fix missed uses of READ_FROM and WRITE_TO
Browse files Browse the repository at this point in the history 
These uses were added in https://crrev.com/c/5848368, which was
submitted to the CQ in parallel with https://crrev.com/c/5858162,
which renamed these symbols

This is causing test failures. See https://crrev.com/c/5861722

Bug: 361372446
Change-Id: I793d5624fc6e1e5de3e3ab7a7eb3732c39a00163
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5862206
Reviewed-by: Brad Triebwasser <[email protected]>
Commit-Queue: Brad Triebwasser <[email protected]>
Auto-Submit: Austin Sullivan <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1355524}
  • Loading branch information
@a-sully @chromium-wpt-export-bot
a-sully authored and chromium-wpt-export-bot committed Sep 14, 2024
1 parent d61fe6d commit 8b875c4
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions webnn/conformance_tests/inputs-are-not-modified.https.any.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,10 @@ promise_test(async () => {
mlContext.createTensor({
dataType: 'float32',
dimensions: [4],
usage: MLTensorUsage.WRITE_TO | MLTensorUsage.READ_FROM
usage: MLTensorUsage.WRITE | MLTensorUsage.READ
}),
mlContext.createTensor(
{dataType: 'float32', dimensions: [4], usage: MLTensorUsage.READ_FROM}),
{dataType: 'float32', dimensions: [4], usage: MLTensorUsage.READ}),
builder.build({'output': outputOperand})
]);

Expand Down Expand Up @@ -66,10 +66,10 @@ promise_test(async () => {
mlContext.createTensor({
dataType: 'float32',
dimensions: [4],
usage: MLTensorUsage.WRITE_TO | MLTensorUsage.READ_FROM
usage: MLTensorUsage.WRITE | MLTensorUsage.READ
}),
mlContext.createTensor(
{dataType: 'float32', dimensions: [4], usage: MLTensorUsage.READ_FROM}),
{dataType: 'float32', dimensions: [4], usage: MLTensorUsage.READ}),
builder.build({'output': outputOperand})
]);

Expand Down

9 comments on commit 8b875c4

@community-tc-integration
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh oh! Looks like an error!

HttpError: You have exceeded a secondary rate limit. Please wait a few minutes before you try again. If you reach out to GitHub Support for help, please include the request ID AA50:103DA2:2A405B8:506C5B3:66E5261B.

@community-tc-integration
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh oh! Looks like an error!

HttpError: You have exceeded a secondary rate limit. Please wait a few minutes before you try again. If you reach out to GitHub Support for help, please include the request ID DF58:3AA10A:2A28344:501DF5E:66E5261B.

@community-tc-integration
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh oh! Looks like an error!

HttpError: You have exceeded a secondary rate limit. Please wait a few minutes before you try again. If you reach out to GitHub Support for help, please include the request ID AA42:281053:28AD6FA:4D621BA:66E5261B.

@community-tc-integration
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh oh! Looks like an error!

HttpError: You have exceeded a secondary rate limit. Please wait a few minutes before you try again. If you reach out to GitHub Support for help, please include the request ID AA38:18759A:298595D:4EF06E7:66E5261B.

@community-tc-integration
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh oh! Looks like an error!

HttpError: You have exceeded a secondary rate limit. Please wait a few minutes before you try again. If you reach out to GitHub Support for help, please include the request ID DF2A:18759A:29859B0:4EF0787:66E5261B.

@community-tc-integration
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh oh! Looks like an error!

HttpError: You have exceeded a secondary rate limit. Please wait a few minutes before you try again. If you reach out to GitHub Support for help, please include the request ID AA38:18759A:2985A3B:4EF08A5:66E5261B.

@community-tc-integration
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh oh! Looks like an error!

HttpError: You have exceeded a secondary rate limit. Please wait a few minutes before you try again. If you reach out to GitHub Support for help, please include the request ID AA50:103DA2:2A40705:506C84A:66E5261B.

@community-tc-integration
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh oh! Looks like an error!

HttpError: You have exceeded a secondary rate limit. Please wait a few minutes before you try again. If you reach out to GitHub Support for help, please include the request ID AA38:18759A:2985A69:4EF08FD:66E5261B.

@community-tc-integration
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh oh! Looks like an error!

HttpError: You have exceeded a secondary rate limit. Please wait a few minutes before you try again. If you reach out to GitHub Support for help, please include the request ID AA50:103DA2:2A407B7:506C993:66E5261B.

Please sign in to comment.