Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a key to SVG #2054

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add a key to SVG #2054

wants to merge 1 commit into from

Conversation

Elchi3
Copy link
Collaborator

@Elchi3 Elchi3 commented Oct 23, 2024

@github-actions github-actions bot added the feature definition Creating or defining new features or groups of features. label Oct 23, 2024
jamesnw
jamesnw requested changes Oct 23, 2024
View reviewed changes
Copy link
Collaborator

@jamesnw jamesnw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think stroke-color should be part of SVG. Per the spec, it should apply to both text and svg elements, but currently only Safari does that, and the prefixed -webkit-text-stroke-color is part of the compat standard.

Alternatively, since it only works cross-platform in SVG, we could include it here, and then when a BCD key like css.properties.stroke-color.non-svg-text is added, we could create a separate feature.

Which makes the most sense?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesnw jamesnw jamesnw requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
feature definition Creating or defining new features or groups of features.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Elchi3 @jamesnw