Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use content hash as [base] and [name] for extracted DataURIs #8148

Merged
merged 1 commit into from
Oct 18, 2024
Merged

fix: use content hash as [base] and [name] for extracted DataURIs #8148

merged 1 commit into from
Oct 18, 2024

Conversation

inottn
Copy link
Contributor

@inottn inottn commented Oct 16, 2024

Summary

See webpack/webpack#18778 for more details.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label Oct 16, 2024
@netlify Netlify
Copy link

netlify bot commented Oct 16, 2024 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit bc88638
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/670febe8b61cc800083f565e

LingyuCoder
LingyuCoder approved these changes Oct 18, 2024
View reviewed changes
Copy link
Collaborator

@LingyuCoder LingyuCoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@LingyuCoder LingyuCoder merged commit 836ad3c into web-infra-dev:main Oct 18, 2024
34 checks passed
@inottn inottn deleted the fix/data-uri branch October 18, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LingyuCoder LingyuCoder LingyuCoder approved these changes

Assignees
No one assigned
Labels
release: bug fix release: bug related release(mr only)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@inottn @LingyuCoder