Support gitlab subgroup and subsubgroups etc when creating PRs

[foot]

Closes #2281

What changed?

• We hack around some bad validation in go-git-providers Support sub-groups and sub-sub-groups on gitlab fluxcd/go-git-providers#183
  • It raises an error if there are any subgroups present, and ignores them when doing requests.
• The gitlab api is happy to treat a fully qualified subgroup the same as a group in its api requests so we
  • 1. Replace the group with the groups + subgroup to make the correct api calls
  • 2. Clear the subgroups to avoid the validation

Why was this change made?

So we can easily support gitlab sub-org / sub-groups in WGE

How was this change implemented?

• We fix the repoRef in the single place we ask ggp to parse the url into a reporef.
• Also removes some unused clone code.

How did you validate the change?

• Manually
• Integration tests

Release notes

Documentation Changes

To test...

• tilt up cluster-service

• kubectl create secret generic git-provider-credentials --namespace=flux-system \
  --from-literal="GITLAB_CLIENT_ID=8dcc1729811e1233469a5c1df201b1685fee5808b7c2a44633bfd420095f0bef" \
  --from-literal="GITLAB_CLIENT_SECRET=1b3f5c9ac5d341046de6b8f44bde626c49305b1ec6df5f1c6c7657e32b9ad499" \
  --from-literal="GITLAB_HOSTNAME=gitlab.git.dev.weave.works" \
  --from-literal="GIT_HOST_TYPES=gitlab.git.dev.weave.works=gitlab"
  

• flux create source git wge-sub-dev --url ssh://[email protected]/wge/foot/infra/wge-sub-dev.git --namespace flux-system --branch main
• Open https://gitlab.git.dev.weave.works/wge/foot/infra/wge-sub-dev/-/settings/repository#js-deploy-keys-settings and add the displayed deploy key
• Create a cluster from template, choose the new gitrepo, auth and create PR should work

[foot]

Without fix:

❯ GIT_PROVIDER_HOSTNAME=gitlab.git.dev.weave.works go test -timeout 30s -tags integration -run ^TestCreatePullRequestInGitLab$ ./pkg/git/...
--- FAIL: TestCreatePullRequestInGitLab (1.63s)
    git_test.go:255:
        	Error Trace:	/Users/simon/weave/weave-gitops-enterprise/cmd/clusters-service/pkg/git/git_test.go:255
        	Error:      	Received unexpected error:
        	            	unable to get repo: unable to get repository "https://gitlab.git.dev.weave.works/capi-server-test-repo-958/foo/capi-server-test-repo-group-test.git": gitlab doesn't support sub-organizations: no provider support for this feature, (client domain: https://gitlab.git.dev.weave.works)
        	Test:       	TestCreatePullRequestInGitLab
    git_test.go:258:
        	Error Trace:	/Users/simon/weave/weave-gitops-enterprise/cmd/clusters-service/pkg/git/git_test.go:258
        	Error:      	Received unexpected error:
        	            	GET https://gitlab.git.dev.weave.works/api/v4/projects/10816/merge_requests/1: 404 {message: 404 Not found}
        	Test:       	TestCreatePullRequestInGitLab
FAIL
FAIL	github.com/weaveworks/weave-gitops-enterprise/cmd/clusters-service/pkg/git	1.896s
FAIL

With Fix!

❯ GIT_PROVIDER_HOSTNAME=gitlab.git.dev.weave.works go test -timeout 30s -tags integration -run ^TestCreatePullRequestInGitLab$ ./pkg/git/...
ok  	github.com/weaveworks/weave-gitops-enterprise/cmd/clusters-service/pkg/git	4.341s

[bigkevmcd]

Thanks for the extra tests!