Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add guardrails workflow [skip deploy] #4

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

cchawn
Copy link
Member

@cchawn cchawn commented Oct 7, 2024

Warning

This PR was opened automatically Please review it carefully for changes Reach out to #developer-tools on Slack if you have any questions!

https://wealthsimple.atlassian.net/browse/BEPLAT-1239

Why

Developer Tools is rolling out a new "Guardrails" workflow across all repositories.

This workflow calls a shared workflow on PR open, edit, or synchronize. The workflow includes essential language-agnostic checks to enforce best practices. At the moment, this includes checks for:

  1. Any Slack URLs in the code (currently enabled)
  2. A Jira issue referenced in the PR title/body or branch name – read the announcement for more context (currently disabled)

Important

The new Guardrails check is currently not required to merge PRs!

What Changed

  • Add a new guardrails.yml GitHub workflow

@cchawn cchawn requested a review from a team as a code owner October 7, 2024 13:40
Copy link
Contributor

@rperryng rperryng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!
:shipit: 🔥

@cchawn cchawn merged commit 5991073 into main Oct 10, 2024
1 check passed
@cchawn cchawn deleted the BEPLAT-1239-guardrails-workflow branch October 10, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants