Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove duplicate guardrails [skip deploy] #148

Closed
wants to merge 1 commit into from

Conversation

scottybarr
Copy link
Contributor

Why

We recently rolled out this new Guardrails workflow to every repository, but
I've discovered we don't actually need it! 🙈

I learned that GitHub rulesets can require a specific, shared workflow to pass
for every repository instead! So, I have created an org ruleset that requires
the
guardrails workflow
in github-workflows to pass before merging to the default branch. This applies
to all repositories, but it is currently not a blocker for merging.

The problem we have now is that there are two guardrails checks running on
every PR
(the one from the ruleset and the one from the workflow in each
repo).

image

Maintaining a single ruleset is easier than maintaining workflow files in our
~400 active repositories. So let's keep it simple!

https://wealthsimple.atlassian.net/browse/BEPLAT-1468

What Changed

  • Delete the guardrails.yml GitHub workflow file

[!WARNING] This PR was opened automatically Please review it carefully for
changes! Reach out to
#backend-platform-on-call
on Slack if you have any questions

@scottybarr scottybarr requested a review from a team as a code owner October 25, 2024 18:02
@cchawn
Copy link
Member

cchawn commented Oct 25, 2024

I actually want to keep this for public repos, since we've excluded them from the "Enforce Guardrails" ruleset.

@cchawn cchawn closed this Oct 25, 2024
@cchawn cchawn deleted the BEPLAT-1468-remove-guardrails-workflow branch October 25, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants