ci: remove duplicate guardrails [skip deploy] #148
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
We recently rolled out this new Guardrails workflow to every repository, but
I've discovered we don't actually need it! 🙈
I learned that GitHub rulesets can require a specific, shared workflow to pass
for every repository instead! So, I have created an org ruleset that requires
the
guardrails workflow
in
github-workflows
to pass before merging to the default branch. This appliesto all repositories, but it is currently not a blocker for merging.
The problem we have now is that there are two guardrails checks running on
every PR (the one from the ruleset and the one from the workflow in each
repo).
Maintaining a single ruleset is easier than maintaining workflow files in our
~400 active repositories. So let's keep it simple!
https://wealthsimple.atlassian.net/browse/BEPLAT-1468
What Changed
guardrails.yml
GitHub workflow file