-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added ability to override visibility_timeout (default 30 seconds) #126
Conversation
lib/pheme/queue_poller.rb
Outdated
@@ -28,10 +29,12 @@ def initialize(queue_url:, | |||
@poller_configuration = { | |||
wait_time_seconds: 10, # amount of time a long polling receive call can wait for a message before receiving a empty response (which will trigger another polling request) | |||
idle_timeout: 20, # disconnects poller after 20 seconds of idle time | |||
visibility_timeout: 30, # amount of time to process and delete the message before it is added back into the queue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one more quick question - where did the 30
come from? In the docs it says the default is nil
I think:
:visibility_timeout (Integer) — default: nil — The number of seconds you have to process a message before it is put back into the queue and can be received again. By default, the queue's visibility timeout is not set.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch! Thank you. I went through the source code and you're correct. I'll update the default to be nil
What confused me at first was this in the documentation.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
This issue has been automatically closed because it has had no activity for over 90 days. Please re-open if you feel this was done in error. |
Why
We are seeing a large increase in transactions per batch in
poseidon
and need a way to increase thevisibility_timeout
, the default 30 seconds is not enough. Followed the AWS documentation onvisibility_timeout
.What changed
Added ability to override the
visibility_timeout
from 30 seconds.