Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backhand: Data duplication flag should be kept from reader #603

Merged

Conversation

wcampbell0x2a
Copy link
Owner

  • When using binaries such as add, or mutate the deduplicatin setting should be used that was read from the reader if we can

Copy link

Benchmark for 9cba2bb

Click to view benchmark
Test Base PR %
only_read/netgear_ax6100v2 2.4±0.00ms 2.3±0.01ms -4.17%
only_read/tplink_ax1800 6.2±0.01ms 6.2±0.02ms 0.00%
unsquashfs/full 10.9±0.24ms 11.0±0.29ms +0.92%
unsquashfs/full-path-filter 7.6±0.17ms 7.7±0.19ms +1.32%
unsquashfs/list 7.9±0.16ms 8.0±0.18ms +1.27%
unsquashfs/list-path-filter 7.1±0.19ms 7.1±0.17ms 0.00%
write_read/netgear_ax6100v2 1281.0±4.02ms 1295.3±13.12ms +1.12%
write_read/tplink_ax1800 7.1±0.02s 7.2±0.05s +1.41%

* When using binaries such as add, or mutate the deduplicatin setting
  should be used that was read from the reader if we can
@wcampbell0x2a wcampbell0x2a force-pushed the 223-duplicate-data-setting-should-be-kept-from-reader branch from 809844c to a2d947b Compare August 30, 2024 02:52
@github-actions github-actions bot added the A-tests bakchand-tests label Aug 30, 2024
Copy link

Benchmark for 87b6b9f

Click to view benchmark
Test Base PR %
only_read/netgear_ax6100v2 2.3±0.00ms 2.3±0.00ms 0.00%
only_read/tplink_ax1800 6.2±0.01ms 6.2±0.01ms 0.00%
unsquashfs/full 10.9±0.20ms 11.0±0.25ms +0.92%
unsquashfs/full-path-filter 7.6±0.09ms 7.6±0.12ms 0.00%
unsquashfs/list 8.0±0.15ms 7.9±0.07ms -1.25%
unsquashfs/list-path-filter 7.0±0.05ms 7.0±0.06ms 0.00%
write_read/netgear_ax6100v2 1269.7±2.85ms 1277.7±5.09ms +0.63%
write_read/tplink_ax1800 7.0±0.02s 7.0±0.01s 0.00%

@wcampbell0x2a wcampbell0x2a merged commit 2981a20 into master Aug 30, 2024
38 checks passed
@wcampbell0x2a wcampbell0x2a deleted the 223-duplicate-data-setting-should-be-kept-from-reader branch August 30, 2024 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-backhand-cli A-backhand-lib A-tests bakchand-tests A-unsquashfs backhand-cli: unsquashfs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant