New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backhand: Fix clippy::incorrect_clone_impl_on_copy_type #277

Merged

wcampbell0x2a merged 1 commit into master from fix-incorrect-manual-clone

Jul 19, 2023

Owner

wcampbell0x2a commented Jul 18, 2023

Remove manual Clone impl for FilesystemReaderFile.
See: https://rust-lang.github.io/rust-clippy/master/index.html#/incorrect_clone_impl_on_copy_type

If both Clone and Copy are implemented, they must agree.
This is done by dereferencing self in Clone’s implementation.
Anything else is incorrect.


backhand: Fix clippy::incorrect_clone_impl_on_copy_type

ffa76cb

* Remove manual Clone impl for FilesystemReaderFile.
* See: https://rust-lang.github.io/rust-clippy/master/index.html#/incorrect_clone_impl_on_copy_type
  >  If both Clone and Copy are implemented, they must agree.
  > This is done by dereferencing self in Clone’s implementation.
  > Anything else is incorrect.

wcampbell0x2a force-pushed the fix-incorrect-manual-clone branch from a3cca11 to ffa76cb Compare

July 18, 2023 01:14

wcampbell0x2a merged commit 4ec76d9 into master

25 checks passed

wcampbell0x2a deleted the fix-incorrect-manual-clone branch

July 19, 2023 04:18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment