Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Scroll on highlight cairo segment when moving through the exec… #146

Merged
merged 2 commits into from
Apr 15, 2024
Merged

chore: Scroll on highlight cairo segment when moving through the exec… #146

merged 2 commits into from
Apr 15, 2024

Conversation

BlackStarkGoku
Copy link
Contributor

…ution trace

@barabanovro barabanovro self-requested a review April 12, 2024 09:41
barabanovro
barabanovro requested changes Apr 12, 2024
View reviewed changes
Copy link
Contributor

@barabanovro barabanovro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The editor should not scroll if any highlighted code segment is already in a viewport.

@barabanovro barabanovro linked an issue Apr 12, 2024 that may be closed by this pull request
feat: Scroll to active Cairo code segment #144
Closed
@barabanovro barabanovro self-requested a review April 15, 2024 12:17
barabanovro
barabanovro approved these changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@barabanovro barabanovro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@barabanovro barabanovro merged commit 66eca55 into walnuthq:main Apr 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barabanovro barabanovro barabanovro approved these changes

Assignees
No one assigned
Labels
safe to preview
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: Scroll to active Cairo code segment
2 participants
@BlackStarkGoku @barabanovro