New debugInfo and console section #136
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mazurroman
requested changes
Apr 8, 2024
| > | ||
| <div className="text-gray-500 dark:text-gray-400 uppercase text-[11px]"> |
There was a problem hiding this comment.
Instead of text-[11px] lets use font-medium to keep consistency with titles in the debug info section
| @@ -317,90 +318,101 @@ const Editor = ({ readOnly = false }: Props) => { | |||
| > | |||
| <div | |||
| className={cn( | |||
| 'w-full md:w-1/2 flex flex-col', | |||
There was a problem hiding this comment.
What is the reason for this change on line 320? It will break the app on mobile screen..
| 'w-full md:w-1/2 flex flex-col', | ||
| isThreeColumnLayout && 'md:w-1/3', | ||
| 'w-1/2 flex flex-col', | ||
| isThreeColumnLayout && 'md:w-2/3', |
There was a problem hiding this comment.
If isThreeColumtLayout is true, the md:w-1/2 class should be removed.
| withLogo={isFullScreen} | ||
| /> | ||
| </div> | ||
| <div className="flex" style={{ height: 'calc(100% - 22vh)' }}> |
There was a problem hiding this comment.
Why are we setting the height here? Can it be removed? We should be able to just use grow to avoid setting any constant values here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.