Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle comment/uncomment line via shortcut #107

Merged
merged 3 commits into from
Mar 20, 2024

Conversation

kwkr
Copy link
Contributor

@kwkr kwkr commented Mar 18, 2024

closes #96

  • allows for commenting/uncommenting single/multiple lines
  • preserves cursor position/selection

@kwkr kwkr requested a review from a team as a code owner March 18, 2024 22:09
@kwkr kwkr force-pushed the feat/comment-line-shortcut branch from 15603a0 to f35447f Compare March 18, 2024 22:12
@mazurroman
Copy link
Contributor

added some minor comments @kwkr

components/Editor/index.tsx Outdated Show resolved Hide resolved
components/Editor/index.tsx Outdated Show resolved Hide resolved
components/Editor/index.tsx Outdated Show resolved Hide resolved
components/Editor/index.tsx Outdated Show resolved Hide resolved
@mazurroman
Copy link
Contributor

@kwkr can you comment on #96

@mazurroman mazurroman self-requested a review March 20, 2024 09:59
Copy link
Contributor

@mazurroman mazurroman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! great work @kwkr

@kwkr how are you backend skills? let me know if this sounds interesting to you: https://walnut.dev/careers/senior-backend-engineer

@mazurroman mazurroman merged commit 19d6735 into walnuthq:main Mar 20, 2024
2 checks passed
@kwkr kwkr deleted the feat/comment-line-shortcut branch March 20, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Feature to "comment" (add // to) lines with a shortcut
2 participants